Fix(Table): Correct column reorder drag logic in RTL mode #19311
+16
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #19312
Description
This PR fixes the column reordering logic when the document direction is RTL.
The Problem:
The
onColumnDragEntermethod calculateddropPositionbased solely on LTR assumptions:pageX > columnCenter(Right Half) always meantdropPosition = 1(After).The Fix:
getComputedStyle().direction === 'rtl'.dropPositionlogic in RTL:dropPosition = -1(Before).dropPosition = 1(After).reorderIndicatorUp/Down) positioning:style.leftbased on the physical edge (Left vs. Right) corresponding to the logical "Before/After" position in the current text direction.Scope
Table(specificallyonColumnDragEnter).Visual Proof / Reproduction
Tested in RTL mode: