Fix friendly error handling in color APIs to prevent runtime crashes #8473
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8458
While testing color-related APIs in p5.js 2.x, I noticed that several functions emit a Friendly Error but still throw runtime exceptions (e.g. TypeError, uncaught Error), causing sketches to crash.
Friendly Errors are generally expected to report invalid input and fail gracefully without terminating execution, but this behavior was inconsistent across color APIs.
This PR improves error handling in
color “creating & reading” functions to ensure that after a Friendly Error is logged, execution exits safely instead of throwing.