notify: classify Discord and Webex failure reasons

[yuminn-k]

Pull Request Checklist

Please check all the applicable boxes.

• Please list all open issue(s) discussed with maintainers related to this change
  • Part of Include status code label to the numTotalFailedNotifications for all notifiers #3231
• Is this a new Receiver integration?
  • I have already tried to use the Webhook Receiver Integration and 3rd party integrations before adding this new Receiver Integration
• Is this a bugfix?
  • I have added tests that can reproduce the bug which pass with this bugfix applied
• Is this a new feature?
  • I have added tests that test the new feature's functionality
• Does this change affect performance?
  • I have provided benchmarks comparison that shows performance is improved or is not degraded
  • I have added new benchmarks if required or requested by maintainers
• Is this a breaking change?
  • My changes do not break the existing cluster messages
  • My changes do not break the existing api
• I have added/updated the required documentation
• I have signed-off my commits
• I will follow best practices for contributing to this project

Which user-facing changes does this PR introduce?

[BUGFIX] discord, webex: Classify failed notification metrics by HTTP status reason. #3231

Summary

• Wrap Discord and Webex non-2xx notification errors with status-code-derived failure reasons.
• Add regression tests for client and server error classifications.
• Add a changelog entry for Include status code label to the numTotalFailedNotifications for all notifiers #3231.

Tests

• make common-format
• go test ./notify/discord
• go test ./notify/webex
• go test ./notify/...
• /Users/yuminkim/go/bin/golangci-lint run ./notify/discord ./notify/webex
• git diff --check

Notes

• go test ./... was attempted, but this fresh checkout lacks built UI assets and local alertmanager/amtool binaries required by package setup and acceptance tests.

[coderabbitai]

📝 Walkthrough

Walkthrough

Discord and Webex now wrap retrier failures with reasons derived from HTTP status codes. New tests cover client and server error responses for both notifiers. The changelog records the bugfix.

Changes

Notification failure reasons

Layer / File(s)	Summary
Retry-check errors carry reasons notify/discord/discord.go, notify/webex/webex.go, CHANGELOG.md	Notify in both notifiers now wraps retrier check errors with notify.NewErrorWithReason(...) from the HTTP status code, and the unreleased changelog notes the bugfix.
Failure reasons are tested notify/discord/discord_test.go, notify/webex/webex_test.go	Table-driven tests start httptest webhook servers for 400 and 500 responses and assert Notify returns *notify.ErrorWithReason with the expected notify.Reason.

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately summarizes the Discord/Webex failure-reason classification change.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The PR description follows the template and includes the checklist, linked issue, release notes, summary, tests, and notes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[siavashs]

I think this should be fixed as part of #5332