-
Notifications
You must be signed in to change notification settings - Fork 70
Migrate to Emscripten's native Bazel rules. #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Envoy PR: envoyproxy/envoy#19579. |
@lambdai @kyessenov @douglas-reid FYI, as this is going to break the auto-update in Istio Proxy. Most notably, the path to generated |
Hold for some fixes. |
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Splitting this into 2 parts: update to Emscripten v3.1.1 (#133) and migration to |
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
This is on hold until emscripten-core/emsdk#971 and emscripten-core/emsdk#972 are fixed. |
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
…3.1.1 Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Instead, declare it only for Proxy-Wasm C++ SDK source files. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Note: This breaks Proxy-Wasm plugins that use I've added support for |
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora When I tried to upgrade to this SHA in our WASM module, it is breaking boost dependency. It works with previous SHA. Below is the error I am getting:
Any suggestions on how to proceed? It works with the previous commit.I suspect some defaults have changed with the bazel rules. WORKSPACE:
bazel Build file:
|
Signed-off-by: Piotr Sikora piotrsikora@google.com