Skip to content

ENH: add check-sign command#166

Merged
Lucas-C merged 10 commits intopy-pdf:mainfrom
moormaster:feat/add-check-sign-command
Oct 12, 2025
Merged

ENH: add check-sign command#166
Lucas-C merged 10 commits intopy-pdf:mainfrom
moormaster:feat/add-check-sign-command

Conversation

@moormaster
Copy link
Copy Markdown
Contributor

  • adds a check-sign command
  • uses endesive to verify pdf signature against a PEM certificate (.pem, .crt, ...)
@moormaster moormaster force-pushed the feat/add-check-sign-command branch from 5187ff3 to c05f5a8 Compare October 9, 2025 09:01
@moormaster moormaster marked this pull request as ready for review October 9, 2025 09:02
@moormaster moormaster mentioned this pull request Oct 9, 2025
7 tasks
@moormaster moormaster force-pushed the feat/add-check-sign-command branch from b6d2c6a to b24b794 Compare October 9, 2025 19:43
@Lucas-C
Copy link
Copy Markdown
Member

Lucas-C commented Oct 10, 2025

Could you also please add a mention of this new feature in CHANGELOG.md as part of this PR?

I'll answer your comments in a few hours, can't do it right now, but thank you for all your work on this 👍

@moormaster moormaster force-pushed the feat/add-check-sign-command branch from b24b794 to 17c85fd Compare October 10, 2025 11:48
@moormaster moormaster changed the title FEAT: add check-sign command Oct 10, 2025
@moormaster moormaster force-pushed the feat/add-check-sign-command branch from 17c85fd to 2a38418 Compare October 10, 2025 11:50
@moormaster
Copy link
Copy Markdown
Contributor Author

Could you also please add a mention of this new feature in CHANGELOG.md as part of this PR?

Added an entry to CHANGELOG.md and fixed commit message & PR title: FEAT -> ENH

@moormaster moormaster force-pushed the feat/add-check-sign-command branch 2 times, most recently from ca6e14b to 835b1e2 Compare October 10, 2025 13:15
@moormaster moormaster force-pushed the feat/add-check-sign-command branch from 95f57ff to 96fe6dc Compare October 10, 2025 16:47
@moormaster
Copy link
Copy Markdown
Contributor Author

Added endesive dependencies to pyproject.toml in original ENH: commit

@moormaster moormaster force-pushed the feat/add-check-sign-command branch from 7b4a7f2 to c883519 Compare October 10, 2025 17:37
@moormaster
Copy link
Copy Markdown
Contributor Author

Rebased on main

@Lucas-C Lucas-C merged commit 17711e6 into py-pdf:main Oct 12, 2025
8 checks passed
@Lucas-C
Copy link
Copy Markdown
Member

Lucas-C commented Oct 12, 2025

Merged, thank you @moormaster 🙏

@moormaster moormaster deleted the feat/add-check-sign-command branch October 12, 2025 16:45
@Lucas-C
Copy link
Copy Markdown
Member

Lucas-C commented Oct 13, 2025

This new command has been included in the latest 0.5.0 release: https://github.com/py-pdf/pdfly/releases/tag/0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants