Skip to content

Conversation

@alexmojaki
Copy link
Contributor

No description provided.

Copy link

Copilot AI commented Nov 25, 2025

@alexmojaki I've opened a new pull request, #1549, to work on those changes. Once the pull request is ready, I'll request review from you.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 25, 2025

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 896bd14
Status: ✅  Deploy successful!
Preview URL: https://c0fd8055.logfire-docs.pages.dev
Branch Preview URL: https://managed-variables.logfire-docs.pages.dev

View logs

@dmontagu dmontagu marked this pull request as ready for review December 2, 2025 23:24
Comment on lines 234 to 251
assert 'orphan-feature' in diff.orphaned_server_variables
assert 'my-feature' not in diff.orphaned_server_variables
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace as many assertions as possible with inline-snapshot

@alexmojaki alexmojaki marked this pull request as draft December 19, 2025 18:14
@dmontagu dmontagu changed the title Initial work on managed variables Dec 29, 2025
@alexmojaki alexmojaki mentioned this pull request Jan 7, 2026
dmontagu and others added 11 commits January 8, 2026 02:49
- Add override_variables() context manager for batch overrides
- Add explicit variant selection via use_variant() and get(variant=)
- Add prompt_var() convenience for string prompt variables
- Add var_bundle() for grouping related variables
- Add VariableBundle class with override, get_all, and dict-like access
- Add 19 new tests for all new functionality

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants