Skip to content

Handle all schema generation errors in InstanceOf #12705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Viicos wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Handle all schema generation errors in InstanceOf #12705

Viicos wants to merge 2 commits into from
+30 −5

Conversation

@Viicos
Copy link
Member

@Viicos Viicos commented Jan 14, 2026

Change Summary

Related issue number

Fixes #12704.

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers
@Viicos Viicos requested a review from davidhewitt January 14, 2026 14:50
@Viicos Viicos added the relnotes-fix Used for bugfixes. label Jan 14, 2026
Viicos
Viicos commented Jan 14, 2026
View reviewed changes
pydantic/functional_validators.py
Copy link
Member Author

@Viicos Viicos Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd have a base exception encapsulating all of them, but this isn't trivial to do because some exceptions are used outside schema generation as well
Copy link
Collaborator

@davidhewitt davidhewitt Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to handle this same group in multiple places? If so, maybe worth defining a private tuple _SCHEMA_GENERATION_EXCEPTIONS?
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 14, 2026 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 87e6029
Status: ✅  Deploy successful!
Preview URL: https://d770c1c2.pydantic-docs.pages.dev
Branch Preview URL: https://vp-instance-of-errors.pydantic-docs.pages.dev

View logs
@Viicos Viicos force-pushed the vp/instance-of-errors branch from 355b869 to 77f95b0 Compare January 14, 2026 14:53
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 14, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 212 untouched benchmarks

Comparing vp/instance-of-errors (87e6029) with main (de141b5)

Open in CodSpeed
@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2026

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  functional_validators.py
Project Total  

This report was generated by python-coverage-comment-action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes.

4 participants

@Viicos @davidhewitt @hramezani