Fix Per Tensor 3d rehsape #2293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drisspg
added a commit
that referenced
this pull request
Jun 3, 2025
stack-info: PR: #2293, branch: drisspg/stack/64
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2293
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a18d989 with merge base 9d5b9ad ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
drisspg
added
the
topic: not user facing
drisspg
added a commit
that referenced
this pull request
Jun 3, 2025
stack-info: PR: #2293, branch: drisspg/stack/64
stack-info: PR: #2293, branch: drisspg/stack/64
|
Pulling this down to try it out on Flux.. |
jbschlosser
approved these changes
Jun 3, 2025
There was a problem hiding this comment.
Works for me, thanks for the fix :)
Ideally, as we discussed offline, determination of rowwise scaling should be fixed in torch as well: https://github.com/pytorch/pytorch/blob/main/torch/_inductor/kernel/mm_common.py#L122
Comment on lines
+97
to
+98
| return output + bias | ||
| return torch._scaled_mm( |
|
@jbschlosser you wanna add yourself as a contributor so I can land this? |
|
@drisspg oh yeah, good call |
jbschlosser
approved these changes
Jun 9, 2025
|
@drisspg try merging now? |
|
@jbschlosser magic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Fix Per Tensor 3d rehsape