Add slicing support for fbgemm fp8 and int4 #2308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2308
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f9c6195 with merge base 35ffb26 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jerryzh168
added
the
topic: improvement
drisspg
reviewed
Jun 6, 2025
drisspg
reviewed
Jun 6, 2025
drisspg
reviewed
Jun 6, 2025
drisspg
reviewed
Jun 6, 2025
|
|
||
|
|
||
| @implements(aten.slice.Tensor) | ||
| def _(func, types, args, kwargs): |
There was a problem hiding this comment.
Maybe a doc block here on what is supported and the semantics this code is not that easy to grok
drisspg
approved these changes
Jun 6, 2025
Summary: att, this is needed in vllm Note that irregular shapes will require padding, which is not implemented right now, we can add that if it's required by the model Test Plan: python test/dtypes/test_fbgemm_fp8.py -k test_slice python test/dtypes/test_fbgemm_int4.py -k test_slice Reviewers: Subscribers: Tasks: Tags:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
att, this is needed in vllm
Note that irregular shapes will require padding, which is not implemented right now, we can add that if it's required by the model
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: