Skip to content

[BE] Rename qparams for tinygemm #2344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

[BE] Rename qparams for tinygemm #2344

merged 1 commit into from
Jun 10, 2025

Conversation

jainapurva
Copy link
Contributor

@jainapurva jainapurva commented Jun 9, 2025 •
edited
Loading

Rename

  • quantize_affine_float_zero_point -> quantize_affine_tinygemm
  • dequantize_affine_float_zero_point -> dequantize_affine_tinygemm
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2344

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 6d4baef with merge base 83663b8 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2025
@jainapurva jainapurva added topic: bc-breaking Use this tag if this PR breaks backward compatibility topic: for developers Use this tag if this PR is mainly developer facing topic: not user facing Use this tag if you don't want this PR to show up in release notes and removed topic: not user facing Use this tag if you don't want this PR to show up in release notes labels Jun 9, 2025
@jainapurva jainapurva requested a review from jerryzh168 June 10, 2025 00:57
@jainapurva jainapurva marked this pull request as ready for review June 10, 2025 17:25
jerryzh168
jerryzh168 reviewed Jun 10, 2025
View reviewed changes
torchao/dtypes/affine_quantized_tensor.py
@@ -26,14 +26,14 @@
choose_qparams_and_quantize_affine_hqq,
dequantize_affine,
dequantize_affine_float8,
dequantize_affine_float_zero_point,
Copy link
Contributor

@jerryzh168 jerryzh168 Jun 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you do a search to see if these are used outside of torchao?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I did a search, looks like not
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, found the same
@jainapurva jainapurva merged commit a581609 into main Jun 10, 2025
27 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: bc-breaking Use this tag if this PR breaks backward compatibility topic: for developers Use this tag if this PR is mainly developer facing
3 participants
@jainapurva @jerryzh168 @facebook-github-bot