Add scale and zero-point dimension validation to quantization primitives#4539
Open
GiGiKoneti wants to merge 2 commits into
Open
Add scale and zero-point dimension validation to quantization primitives#4539GiGiKoneti wants to merge 2 commits into
GiGiKoneti wants to merge 2 commits into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4539
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements upfront shape and size validation for the
scaleandzero_pointtensors in low-level affine quantization and dequantization primitives undertorchao/quantization/quant_primitives.py.It resolves several
# TODO: validate scale/zero_point dimensions are compatible with block_sizecomments in the codebase.By checking these dimensions before entering
.view()calls, we prevent generic PyTorchRuntimeError: shape [...] is invalid for input of size ...and instead raise clear, actionableValueErrorandAssertionErrormessages when dimensions or number of elements are incompatible.Closes #4538
Test Plan
Added unit tests in
test/quantization/test_quant_primitives.py(test_validate_scale_zero_point) and updatedtest_raisesto expect the newValueErrorinstead of the oldRuntimeError.To run the tests:
python3 -m pytest test/quantization/test_quant_primitives.py -k "test_raises or test_validate_scale_zero_point"Output: