[codex] Document v4 chapter info resource support#116
[codex] Document v4 chapter info resource support#116
Conversation
Deploying qf-api-docs with
|
| Latest commit: |
a91fa9e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c20f2b8e.qf-api-docs.pages.dev |
| Branch Preview URL: | https://codex-v4-chapter-info-docs.qf-api-docs.pages.dev |
💡 Codex Reviewhttps://github.com/quran/qf-api-docs/blob/b1e39cb86e0d66af379c6192ce11bcb1464068b0/openAPI/content/v4.json#L15585-L15589 The pagination schema now documents ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Addressed the Codex feedback in ec70c2a. |
|
@codex review |
💡 Codex Reviewhttps://github.com/quran/qf-api-docs/blob/ec70c2a9fb4501086dacd2bc2cd0c1ba4e0e062d/openAPI/content/v4.json#L15255 The https://github.com/quran/qf-api-docs/blob/ec70c2a9fb4501086dacd2bc2cd0c1ba4e0e062d/openAPI/content/v4.json#L15588-L15590 The shared https://github.com/quran/qf-api-docs/blob/ec70c2a9fb4501086dacd2bc2cd0c1ba4e0e062d/openAPI/content/v4.json#L16749-L16751
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Addressed the three Codex findings in 3660d0b.
I also re-generated the content API docs from the corrected These Codex notes were posted as top-level PR conversation comments rather than review threads, so GitHub does not provide a per-comment resolve action or threaded inline reply target for them. |
|
@codex review |
💡 Codex Reviewhttps://github.com/quran/qf-api-docs/blob/3660d0b6b578d4851a1be3c86eca2a024b92f4ee/openAPI/content/v4.json#L8838-L8841 The 200 response schema for https://github.com/quran/qf-api-docs/blob/3660d0b6b578d4851a1be3c86eca2a024b92f4ee/openAPI/content/v4.json#L8968-L8971 The 200 response schema for https://github.com/quran/qf-api-docs/blob/3660d0b6b578d4851a1be3c86eca2a024b92f4ee/openAPI/content/v4.json#L9773-L9777 In ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Addressed the latest Codex review in
I also regenerated the two affected content API pages ( |
|
@codex review |
💡 Codex Reviewhttps://github.com/quran/qf-api-docs/blob/4c9c6e490135ff38544bc78f22e522b3143e2cce/openAPI/content/v4.json#L15197-L15199 The https://github.com/quran/qf-api-docs/blob/4c9c6e490135ff38544bc78f22e522b3143e2cce/openAPI/content/v4.json#L6721-L6724 The ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Addressed the first Codex note in commit I removed Validation:
There is no resolve action available for this specific Codex note because it is a top-level PR conversation comment, not a GitHub review thread. |
|
@codex review |
💡 Codex Reviewhttps://github.com/quran/qf-api-docs/blob/25c12fc07b2cd40a0c7293edfaa04a39ae7ad4a1/openAPI/content/v4.json#L14334-L14338 This changes https://github.com/quran/qf-api-docs/blob/25c12fc07b2cd40a0c7293edfaa04a39ae7ad4a1/openAPI/content/v4.json#L8018-L8022 The parameter list is now closed after path params, dropping query controls like ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Addressed the two latest Codex notes in commit
I regenerated the content API docs from the updated
These Codex notes are still top-level PR conversation comments rather than GitHub review threads, so there is no resolve action available for them. |
|
Superseded by #118. This replacement was rebuilt from a fresh origin/main worktree and keeps only the chapter-info docs changes. |
Summary
openAPI/content/v4.json4.0.0chapter-info docs pages to match the source contractresource_idandinclude_resourceschapter_infocan benullwhen a requested resource does not resolve for the resolved languageWhy
The backend now supports qdc-style resource-aware chapter info in v4, so the published docs need to describe
resource_id,include_resources,chapter_info.resource_id,resources, and how to use the endpoint for specific authors such as Ibn Ashur.Impact
Validation
ruby -rjson -e 'JSON.parse(File.read(%q{openAPI/content/v4.json}))'npx docusaurus build