-
Notifications
You must be signed in to change notification settings - Fork 7.2k
[Data][CI] Move test_push_based_shuffle to postmerg #60633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request moves the test_push_based_shuffle test to a post-merge CI job, likely to improve pre-merge CI speed. The changes correctly tag the test in the Bazel file and update the CI configuration to run it in new post-merge jobs. My review includes a suggestion to refactor the new CI jobs to improve maintainability by reducing code duplication.
| - label: ":database: data: postmerge arrow v9 tests" | ||
| tags: | ||
| - data | ||
| - skip-on-premerge | ||
| instance_type: medium | ||
| commands: | ||
| - bazel run //ci/ray_ci:test_in_docker -- //python/ray/data/... //python/ray/air/... data | ||
| --build-name data9build-py3.10 --python-version 3.10 | ||
| --only-tags skip-on-premerge | ||
| depends_on: data9build-multipy | ||
|
|
||
| - label: ":database: data: postmerge arrow v23 tests" | ||
| tags: | ||
| - data | ||
| - skip-on-premerge | ||
| instance_type: medium | ||
| commands: | ||
| - bazel run //ci/ray_ci:test_in_docker -- //python/ray/data/... //python/ray/air/... data | ||
| --build-name datalbuild-py3.10 --python-version 3.10 | ||
| --only-tags skip-on-premerge | ||
| depends_on: datalbuild-multipy | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two new post-merge test steps are nearly identical. To improve maintainability and reduce code duplication, you can combine them into a single matrix step. This is consistent with how other tests are configured in this file.
- label: ":database: data: postmerge arrow {{matrix.arrow_version}} tests"
matrix:
setup:
arrow_version:
- "v9"
- "v23"
adjustments:
- with:
arrow_version: "v9"
build_name: "data9build-py3.10"
depends_on: "data9build-multipy"
- with:
arrow_version: "v23"
build_name: "datalbuild-py3.10"
depends_on: "datalbuild-multipy"
tags:
- data
- skip-on-premerge
instance_type: medium
commands:
- >
bazel run //ci/ray_ci:test_in_docker -- //python/ray/data/... //python/ray/air/... data
--build-name {{matrix.build_name}} --python-version 3.10
--only-tags skip-on-premerge
depends_on: "{{matrix.depends_on}}"There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
33e7846 to
ca41fb0
Compare
Signed-off-by: win5923 <ken89@kimo.com>
ca41fb0 to
ee4864a
Compare
Description
As title.
Context:
Related issues
Closes #60417
Additional information