[core] Move test_serialization to large bucket
#60636
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sagar Sumit <sagarsumit09@gmail.com>
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request moves test_serialization.py to a larger test bucket to resolve timeouts on Windows. The change is simple and correct. I've added one suggestion to include a comment explaining the reason for this move, which improves the maintainability of the build configuration.
| "test_reconstruction.py", | ||
| "test_reconstruction_2.py", | ||
| "test_runtime_env_working_dir_uri.py", | ||
| "test_serialization.py", |
Contributor
There was a problem hiding this comment.
For better maintainability, consider adding a comment explaining why this test is in the large bucket. This follows a pattern seen elsewhere in this file (e.g., for test_memory_deadlock.py).
Suggested change
| "test_serialization.py", | |
| "test_serialization.py", # Times out on Windows in the medium bucket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_serializationhas been timing out on windows. Increasing the timeout by moving to larger bucket.