[Data] ArrowInvalid error when you backfill missing fields from map tasks #60643
+41
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: machichima <nary12321@gmail.com>
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses an ArrowInvalid error that occurs when backfilling missing fields in struct columns, particularly from map tasks. The issue arises from type mismatches between struct fields in different blocks (e.g., int64 vs. float64) that are not handled after schema unification. The proposed change correctly identifies these type discrepancies and explicitly casts the array to the unified field type. The implementation is clean, includes robust error handling with an informative ValueError, and effectively resolves the bug. The changes look good to me.
Signed-off-by: machichima <nary12321@gmail.com>
Contributor
Author
|
@bveeramani PTAL, thank you! |
ray-gardener
bot
added
data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Try type casting if struct field types mismatch when backfilling missing fields
Related issues
Closes #60628
Additional information