Fix native animated mount flash

[GrahamCampbell]

Summary:

The C++ native animated backend (cxxNativeAnimatedEnabled) prevents the useNativeDriver first-frame flash by having AnimatedMountingOverrideDelegate re-merge a view's live animated props (getManagedProps) onto mount Update mutations, so a stale JS re-render can't reach the screen. There is a residual at connect time: connectAnimatedNodeToView registers the view (the override starts overriding it) but never runs the props node, so getManagedProps() returns an empty object until the next animation frame. If a Fabric mount transaction is pulled in that window the override has nothing to merge and the un-driven default value flashes for one frame, most visibly when a brand-new view is connected to an already mid-flight shared Animated.Value.

This seeds the props node with node->update() at the end of connectAnimatedNodeToView so getManagedProps() is live the instant the view becomes managed. No manager mutex is held at that point and update() takes only the node-local props mutex, so it is lock-safe; it is idempotent with the per-frame update and adds no extra Fabric commit because it only stages. It closes the connect-while-Update-in-flight case and mitigates the brand-new-view (Insert) first-paint case; the override only rewrites Update/Delete mutations today, so fully closing Insert is a follow-up. It also adds the missing unit coverage for the getManagedProps / hasManagedProps seam the override depends on.

Changelog:

[INTERNAL] [FIXED] - Seed managed props when a view connects to the native animated backend so they are live before the first frame, shrinking the useNativeDriver mount flash

Test Plan:

Adds ManagedPropsMountingOverrideTests.cpp to the ReactCommon animated unit tests. getManagedPropsReflectsLiveValueAcrossFrames, getManagedPropsNullForUnconnectedView, hasManagedPropsTracksConnectAndDisconnect and getManagedPropsIsolatedPerView pin the seam and pass regardless of the change. getManagedPropsLiveImmediatelyOnConnect and getManagedPropsLiveOnConnectWhileValueMidFlight are the regression cases: they fail without the seed (empty props at connect) and pass with it. Run via the animated C++ unit test target. On-device verification (iOS and Android with cxxNativeAnimatedEnabled on, frame-stepped capture of a popover/menu open) is still recommended for the user-visible flash.

[zeyap]

Suggested change

	node->update();
	node->update(/*forceFabricCommit*/ true);

[zeyap]

@GrahamCampbell thanks for the PR, do you have a playground repro for this issue? In fact Props node->update() will trigger a commit to the native view, so I'm a bit concerned of the side effects of doing this

[GrahamCampbell]

Thanks for the review. update only stages props (map writes). The actual view push is in commitProps, which it never reaches. connectAnimatedNodeToView already dirties the node, so the commit happens that frame regardless. To make that structural, I pushed a follow-up that seeds via a collect-only collectProps with no schedulePropsCommit.

[GrahamCampbell]

I've pushed a reproducer to https://github.com/GrahamCampbell/react-native/tree/native-animated-mount-flash-repro in GrahamCampbell@fa7f342.

[meta-codesync]

@zeyap has imported this pull request. If you are a Meta employee, you can view this in D110323404.