Remove StatusBar deprecated props / methods#57392
Open
zoontek wants to merge 13 commits into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
…translucent # Conflicts: # packages/react-native/ReactNativeApi.d.ts
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
zoontek
force-pushed
the
remove-status-bar-deprecated-props
branch
from
4ec279e to
ef477ce
Compare
facebook-github-tools
Bot
added
the
Shared with Meta
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D110304943. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Removes long-deprecated
StatusBarAPIs that no longer do anything:backgroundColor/translucentprops andsetBackgroundColor()/setTranslucent()(no effect under edge-to-edge, deprecated since 0.76).networkActivityIndicatorVisibleprop andsetNetworkActivityIndicatorVisible()(unsupported since iOS 13, deprecated since 0.77).Also removes the now-unused native backing (
setColor/setTranslucentAndroid,setNetworkActivityIndicatorVisibleiOS, AndroidDEFAULT_BACKGROUND_COLOR).See #57384.
Changelog:
[GENERAL] [BREAKING] - Remove deprecated
StatusBarbackgroundColor/translucent/networkActivityIndicatorVisibleprops andsetBackgroundColor/setTranslucent/setNetworkActivityIndicatorVisiblemethodsTest Plan:
yarn flow check— passesyarn jest StatusBar— passesyarn test-typescript— passes