Fix Exception in list static filter index assumptions#1120
Conversation
| _cleanup.Add( | ||
| _source.Connect() | ||
| .RemoveKey() | ||
| .Filter(x => x.Age < average) |
There was a problem hiding this comment.
In the test fixture for "RemoveKey", the only thing that should be getting tested is .RemoveKey(), What you're REALLY trying to test for here is behavior in .Filter(), specifically, .Filter()'s ability to support missing indexes. That belongs in the appropriate "Filter" fixture.
There was a problem hiding this comment.
What I was actually trying to demonstrate was what series of calls would lead to the error. This test is really just a step indicating it wasn't the problem. Filter() itself is tested more thoroughly in all the Filter* classes.
There was a problem hiding this comment.
Are you trying to say you want this test removed?
There was a problem hiding this comment.
No, I'm saying move it over to the Filter fixture. .Filter() is the operator here that has defective behavior. If other operators are capable of generating changesets with missing list indexes, .Filter() needs to be able to process them. At least, that's how you've written the fix. With that being a behavior that .Filter() needs, there should ve a test in the Filter fixture that feeds missing indexes into the operator, and verifies that it works.
There was a problem hiding this comment.
There are about 7 files making up the Filter fixture. I moved it to FilterFixture.Static.cs
|
I updated test names and removed the extraneous comment per your feedback. Let me know if those names need further tweaking. I also added another test that moves the |
2 participants
See #1119