Skip to content

Rename Server to HttpServer to avoid class name collisions and ambiguities#417

Merged
WyriHaximus merged 2 commits into
reactphp:masterfrom
clue-labs:httpserver
Jul 27, 2021
Merged

Rename Server to HttpServer to avoid class name collisions and ambiguities#417
WyriHaximus merged 2 commits into
reactphp:masterfrom
clue-labs:httpserver

Conversation

@clue

@clue clue commented Jul 25, 2021

Copy link
Copy Markdown
Member

This changeset renames the Server class to HttpServer to avoid class name collisions and ambiguities.

// deprecated
$server = new React\Http\Server($handler);
$server->listen(new React\Socket\Server($port));

// new
$http = new React\Http\HttpServer($handler);
$http->listen(new React\Socket\Server($port));

The deprecated Server is now an alias for new HttpServer to ensure existing code continues to work as-is.

Comment thread src/Server.php Outdated
Comment thread src/Server.php Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants