Update tests to remove defunct httpbin.org#502
Merged
Conversation
SimonFrings
approved these changes
Jul 7, 2023
SimonFrings
left a comment
SimonFrings
left a comment
Member
There was a problem hiding this comment.
Makes sense, no more failing tests because of this 👍
WyriHaximus
approved these changes
Jul 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bye bye httpbin.org, you've served us well.
The service has been down sporadically for a few months already and there doesn't appear to be a clear path forward (see postmanlabs/httpbin#702 and others). I've replaced most occurrences with httpbingo.org as a drop-in replacement where possible.
We've introduced this a while back via reactphp/http-client#109 before merging the HTTP client with #368 (see also reactphp/socket#105 and #244) and haven't touched this ever since. These tests don't provide a lot of value nowadays given that this is a rather high-level test and the underlying logic is already covered by our unit test suite. Accordingly, removing these tests has no impact on our code coverage.
See also #480, #481 and others, as we'll likely eliminate the legacy
Clientclass in the future