-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add redis v7's ExpireAtNX, ExpireAtXX, ExpireAtGT, ExpireAtLT, PExpireNX, PExpireXX, PExpireGT, PExpireLT, PExpireAtNX, PExpireAtXX, PExpireAtGT, PExpireAtLT #2589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…eNX, PExpireXX, PExpireGT, PExpireLT, PExpireAtNX, PExpireAtXX, PExpireAtGT, PExpireAtLT feat: Add redis v7's NX, XX, GT, LT expireat, pexpire, pexpireat variants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you plan to add tests? as we need to add coverage for the new commands. @carner
ok, I will do it. |
add tests to coverage for the new commands
the tests added. @chayim @SoulPancake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you very much for your contribution @carner :) |
thank you |
@elena-kolevska please review code. |
Hi @carner . Can you please check the box “Allow edits from maintainers.”? I would like to push a commit that cleans up some details, and we can merge this PR. |
the box is checked。 @elena-kolevska |
@monkey92t should we merge? |
@carner Seems this PR was lost a while back. Can you sync with master and see if we can work on a final review of it? |
Let’s see if we can fix the code. @carner let me know if you need any assistance. |
Hello @carner , do you plan to work on this? I can take over if you don't have time. |
Hi ^^
Small commit to add ExpireAtNX, ExpireAtXX, ExpireAtGT, ExpireAtLT of Redis v7
doc: https://redis.io/commands/expireat
Small commit to add PExpireNX, PExpireXX, PExpireGT, PExpireLT of Redis v7
doc: https://redis.io/commands/pexpire
Small commit to add PExpireAtNX, PExpireAtXX, PExpireAtGT, PExpireAtLT of Redis v7
doc: https://redis.io/commands/pexpireat