Skip to content

fix: check if the shard exists to avoid returning nil #3396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

fix: check if the shard exists to avoid returning nil #3396

merged 1 commit into from
Jun 9, 2025

Conversation

cxljs
Copy link
Contributor

@cxljs cxljs commented Jun 7, 2025

close #2711
@cxljs
fix: check if the shard exists to avoid returning nil
0195810 
Signed-off-by: fukua95 <fukua95@gmail.com>
@ndyakov
Copy link
Member

ndyakov commented Jun 9, 2025

@fukua95 thank you for fixing this in the Ring client. We are not trying to suggest users to use Cluster instead of Ring and are not actively improving it at the moment. If you would like you can take a look at the rest of the Ring issues, as they most probably won't be prioritized by the team soon.
@ndyakov ndyakov merged commit 0f40ae3 into redis:master Jun 9, 2025
16 checks passed
@cxljs
Copy link
Contributor Author

cxljs commented Jun 9, 2025

I'll take a look at the other Ring issues and see if there's anything I can help with.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug redis-ring
2 participants
@cxljs @ndyakov