Skip to content

Add sunset and midnight filter presets - #29

Merged
ronak-create merged 1 commit into
ronak-create:mainfrom
xusnitdinov:add-sunset-midnight-filter-presets
Jul 18, 2026
Merged

Add sunset and midnight filter presets#29
ronak-create merged 1 commit into
ronak-create:mainfrom
xusnitdinov:add-sunset-midnight-filter-presets

Conversation

@xusnitdinov

@xusnitdinov xusnitdinov commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds two new one-tap color grades to FILTER_PRESETS in app.js:

  • sunset - warm golden-hour glow: lifted temperature/tint, slight brightness + saturation boost, soft vignette.
  • midnight - cool, moody night look: cooler temperature, darker, higher contrast, stronger vignette.

Both use only existing, already-rendered grade props, so they combine non-destructively with the sliders just like the other presets. The inspector dropdown builds itself from Object.keys(FILTER_PRESETS), so they appear automatically with no extra wiring.

Closes #26

Type of change

  • Bug fix
  • New feature (transition / preset / text anim / effect / API)
  • Docs
  • Refactor / internal

How was it verified?

  • node --check server.js && node --check app.js && node --check mcp-server.js passes
  • Opened the editor and confirmed both presets appear in the inspector's Filter/Color dropdown and apply to a clip with no console errors
  • Confirmed the change in an export (fast or realtime), if it affects rendering
  • Updated CLAUDE.md / README.md if the schema, props, or API changed

Note: the presets only set existing grade props (temperature, tint, brightness, saturation, contrast, vignette) that already flow through the single shared compositor, so preview and export render identically by construction.

Checklist

  • No new runtime dependencies added
  • Preview and export render identically (single compositor)
  • Commits are focused and messages are descriptive
Adds two new one-tap color grades to FILTER_PRESETS:
- sunset: warm golden-hour glow (temperature/tint up, soft vignette)
- midnight: cool, moody night look (cooler temp, darker, higher contrast)

Also updates the enumerated preset list in CLAUDE.md and the preset
count in the README feature list.

Closes ronak-create#26

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Two filter presets, sunset and midnight, were added to FILTER_PRESETS. The README and CLAUDE.md preset references were updated from 12 to 14 entries.

Changes

Filter preset expansion

Layer / File(s) Summary
Add presets and update references
app.js, README.md, CLAUDE.md
FILTER_PRESETS now defines sunset and midnight, and both preset lists document the expanded set of 14 presets.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: plkmarudny

Sequence Diagram(s)

sequenceDiagram
  participant Inspector
  participant FILTER_PRESETS
  participant ClipProperties
  Inspector->>FILTER_PRESETS: Enumerate available presets
  Inspector->>ClipProperties: Apply selected preset
  FILTER_PRESETS->>ClipProperties: Supply sunset or midnight values
Loading
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The changes add the requested presets in app.js and update the related documentation.
Out of Scope Changes check ✅ Passed The documentation edits stay aligned with the preset additions and do not add unrelated scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding the sunset and midnight filter presets.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ronak-create
ronak-create merged commit d0780a5 into ronak-create:main Jul 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants