🩹 fix: Relay status code set by WordPress

[tombroucke]

Fixes #484
WordPress sets a 404 statuscode in the WP::handle_404() method, but that got overwritten by the default status code of the Response class. We can fetch the status set by WP using http_response_code(), and pass that in to the sendHeaders() method. This will relay all status codes, but I'm assuming if WP throws a 301, we should follow that.

Tests are running fine, but this should probably be tested manually.

[retlehs]

Thanks for the PR! With these changes:

❯ curl -I http://example.test/asdf
HTTP/1.1 404 Not Found 

❯ curl -I http://example.test/asdf/
HTTP/1.1 404 OK

"404 OK" probably isn't what we want?

[tombroucke]

I didn't see the response text because of HTTP/2.
If we use the setStatusCode() method, it will also update the statusText.

[retlehs]

❯ curl -I http://example.test/asdf/
HTTP/1.1 404 Not Found

Thank you!

[Log1x]

nice find! does

acorn/src/Roots/Acorn/Application/Concerns/Bootable.php

Line 166 in 8f4d458

$response->setStatusCode(http_response_code());

still end up being necessary?

[tombroucke]

nice find! does

acorn/src/Roots/Acorn/Application/Concerns/Bootable.php

Line 166 in 8f4d458

$response->setStatusCode(http_response_code());

still end up being necessary?

I did some testing and I found this is no longer necessary. The status code is always set twice, the first time (line 166) is not always correct, the second time (line 237) is.

However, I did noticed that the "Poor man's wp cron" requests don't fire the send_headers action, so the status code is only set once (from line 166). We should probably add site_url('wp-cron.php') to the $except collection to have wordpress handle these requests.

$except = collect([
    admin_url(),
    wp_login_url(),
    wp_registration_url(),
    rest_url(),
    site_url('wp-cron.php'),
])->map(fn ($url) => parse_url($url, PHP_URL_PATH))->unique()->filter();