Skip to content

String gsub! - #1768

Merged
soutaro merged 3 commits into
ruby:masterfrom
ksss:string-gsub!
Mar 22, 2024
Merged

String gsub!#1768
soutaro merged 3 commits into
ruby:masterfrom
ksss:string-gsub!

Conversation

@ksss

@ksss ksss commented Mar 18, 2024

Copy link
Copy Markdown
Collaborator

I found next pattern.

'a'.gsub!(/b/).each { }
#=> nil

And I also fixed the cause of the test_gsub! being omit.
Then I have also added more test cases.
@ksss
There is a possibility that nil is returned.
4a4386c 
```rb
'a'.gsub!(/b/).each { }
```
@ksss

ksss commented Mar 18, 2024

Copy link
Copy Markdown
Collaborator Author

Oh, it needs a few more revisions.
@ksss

ksss commented Mar 19, 2024

Copy link
Copy Markdown
Collaborator Author

Ready to merge.
soutaro
soutaro approved these changes Mar 22, 2024
View reviewed changes

@soutaro soutaro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍
@soutaro
soutaro added this pull request to the merge queue Mar 22, 2024
@soutaro soutaro added this to the RBS 3.5 milestone Mar 22, 2024
Merged via the queue into ruby:master with commit 50c9ecd Mar 22, 2024
@ksss
ksss deleted the string-gsub! branch March 22, 2024 01:21
@soutaro soutaro added the Released PRs already included in the released version label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Released PRs already included in the released version

2 participants

@ksss @soutaro