Skip to content

Conversation

@costa
Copy link

@costa costa commented Nov 2, 2025

What was the end-user or developer problem that led to this PR?

See #9001

What is your fix for the problem, implemented in this PR?

Duplicate the functionality implemented in #7547

Make sure the following tasks are checked

p.s. Oh, and also containerised (with docker) test env was added.

Copy link
Member

@hsbt hsbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove Dockerfile and related changes? I don't use that.

If you interest that to use develop RubyGems, please consider to integrate the current devcontainer support of this repository.

@costa
Copy link
Author

costa commented Nov 7, 2025

@hsbt Dear Hiroshi, I'll make just this one attempt to convince you to keep the setup.
I'm using this standard of a simple dockerised bin/test in all my projects, it's dead-simple, explicit and straightforward way to run all the project's tests/specs — in a standard (Docker-based) env — and to have a seal on the code's ultimate correctness, CI/CD or not. I'm open to any suggestions, questions or comments, and I will remove that commit from this PR, of course, to get the rest of the changes merged, if you're unconvinced. Thank you for your work.

@colby-swandale
Copy link
Member

I agree with @hsbt that this is not something we're looking to adopt currently.

@costa
Copy link
Author

costa commented Nov 10, 2025

OK, @hsbt, please confirm, and I'll immediately remove these 39 lines from the 200K+(!) LoC project that might help casual contributors (who are definitely not "we") with a single entry point to running all the tests, having a single dependency (the ubiquitous Docker) at that. No problem.

@hsbt
Copy link
Member

hsbt commented Nov 11, 2025

Please remove them at first.

@costa costa force-pushed the 9001-fix-picking-up-from-7547-dumb-http-git-repo-support-broken branch from abd45e7 to 5510c62 Compare November 11, 2025 21:20
@costa
Copy link
Author

costa commented Nov 11, 2025

Please remove them at first.

@hsbt done

...by a little code duplication; specs are somewhat improved though
@costa costa force-pushed the 9001-fix-picking-up-from-7547-dumb-http-git-repo-support-broken branch from 5510c62 to 9cf802a Compare November 12, 2025 16:48
…up-from-7547-dumb-http-git-repo-support-broken
@costa costa requested a review from hsbt November 15, 2025 20:28
@costa
Copy link
Author

costa commented Dec 12, 2025

@hsbt LGTM

@costa
Copy link
Author

costa commented Dec 19, 2025

ping

@hsbt hsbt changed the title 9001 fix picking up from 7547 dumb http git repo support broken Dec 23, 2025
@costa
Copy link
Author

costa commented Jan 4, 2026

@hsbt Yes, and? Please?

@hsbt
Copy link
Member

hsbt commented Jan 7, 2026

In my understanding with #7547, Why would you want to git clone and use it via a local http server without using the path: option?

@costa
Copy link
Author

costa commented Jan 9, 2026

@hsbt

In my understanding with #7547, Why would you want to git clone and use it via a local http server without using the path: option?

This PR fixes a bug with rubygems functionality which I believe should support everything git supports.

Now, serving git repos with dumb HTTP servers (read-only) is useful in many low-profile scenarios.

In my "self server" (docker-host-based) case, illustrated here: https://medium.com/@costa/git-decentralized-a25f00fd2955 -- when I serve git repos via dumb HTTP, this uses simple p2p sharing stack -- and enables p2p git-based communication, as well as makes container builds straightforward.

@costa
Copy link
Author

costa commented Jan 30, 2026

@hsbt Hi, how're you doing? Now, this PR is one of the oldest open ones. I've just updated its branch. How can I help you with accepting or rejecting it? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants