Skip to content

Safely evaluate parents and path for orphan nodes.#81

Open
edlebert wants to merge 2 commits into
rubycdp:mainfrom
edlebert:fix-null-parentNode
Open

Safely evaluate parents and path for orphan nodes.#81
edlebert wants to merge 2 commits into
rubycdp:mainfrom
edlebert:fix-null-parentNode

Conversation

@edlebert

@edlebert edlebert commented Apr 20, 2019

Copy link
Copy Markdown

It's possible for Cuprite to evaluate the parents or the path for a node
that no longer belongs to the document.
Safely evaluate parents and path for orphan nodes.
b9a67c0 
It's possible for Cuprite to evaluate the parents or the path for a node
that no longer belongs to the document.
@route

route commented Apr 22, 2019

Copy link
Copy Markdown
Member

@edlebert could you describe scenario when it is possible? Looks like also there'a at least one failing test in all builds
@route

route commented Jan 27, 2020

Copy link
Copy Markdown
Member

I'll try to rebase and see if it's useful, didn't hear from you ;)
@edlebert

edlebert commented Jan 27, 2020

Copy link
Copy Markdown
Author

Thank you! Yes, it definitely is an issue. It can happen for "waiting" Capybara code such as expect(page).to have_text 'Some Text' when the DOM can change during evaluation.
@Mifrill

Mifrill commented Aug 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

okay, we have only one fail test after the merge with the updated master. Not bad! I will take a look, it is also nice to have some tests with the scenario
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@edlebert @route @Mifrill