Propagate accept-comment-above-attributes to statements

[blyxyas]

Turns out that things like #[attr]return unsafe { func(); } didn't work because we weren't checking above attributes on statements, only on blocks!

fixes #13189

Useful for Rust-For-Linux

changelog:[undocumented_unsafe_blocks]: Make sure to propagate accept-comment-above-attributes to all statements.

[rustbot]

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[ojeda]

Thanks Alejandra!

If I understand correctly, then all the cases in the issue now will pass because the reason was just that they were statements? Nice, this will help avoid confusion :)

[blyxyas]

then all the cases in the issue now will pass because the reason was just that they were statements?

I'll double-check, but yes, now we should check above attributes for all statements (So items, expressions that end in a ;, expressions that don't end ina a ; so they return their type, and let _ = _s).

Also, I'll make it a priority for the feature freeze to fix all the issues you mentioned in that tracking issue. If Rust-For-Linux encounters a really annoying bug (or even worse, a workflow-breaking bug) ping me/dm me on Zulip and I'll either add it to our Feature Freeze tracking issue, or fix it myself.

(Also, if you have a not-yet-resolved issue that you'd like to highlight, now it's the moment to link it)