Skip to content

Don't call WSACleanup on process exit #141809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't call WSACleanup on process exit #141809

wants to merge 1 commit into from
+18 −16

Conversation

ChrisDenton
Copy link
Member

@ChrisDenton ChrisDenton commented May 31, 2025 •
edited by rustbot
Loading

This isn't necessary as cleanup will happen when the process exits regardless.

fixes #141799
@rustbot
Copy link
Collaborator

rustbot commented May 31, 2025

r? @thomcc

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 31, 2025
@tgross35
Copy link
Contributor

tgross35 commented Jul 1, 2025

@bors2 try jobs=x86_64-msvc-*
@rust-bors
Copy link

rust-bors bot commented Jul 1, 2025

Unknown value for argument "jobs".
@tgross35
Copy link
Contributor

tgross35 commented Jul 1, 2025

@bors2 try jobs=x86_64-msvc-*
@rust-bors
Copy link

rust-bors bot commented Jul 1, 2025

⌛ Trying commit b110d45 with merge 77862f6…

To cancel the try build, run the command @bors2 try cancel.
rust-bors bot added a commit that referenced this pull request Jul 1, 2025
@rust-bors
Auto merge of #141809 - ChrisDenton:no-cleaup, r=<try>
77862f6 
Don't call WSACleanup on process exit

This isn't necessary as cleanup will happen when the process exits regardless.

fixes #141799
try-job: x86_64-msvc-*
@rust-bors
Copy link

rust-bors bot commented Jul 1, 2025

☀️ Try build successful (CI)
Build commit: 77862f6 (77862f64491b3eaa745c29822460416af3b41265, parent: f46ce66fcc3d6058f90ac5bf0930f940f1e7b0ca)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
4 participants
@ChrisDenton @rustbot @tgross35 @thomcc