rustdoc: fix attrs of locally reexported foreign items #141831
+52
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lolbinarycat
force-pushed
the
rustdoc-extern-reexport-135092
branch
from
3ea7aa7 to
6494a7d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lolbinarycat
force-pushed
the
rustdoc-extern-reexport-135092
branch
from
6494a7d to
b400cfa
Compare
This comment has been minimized.
This comment has been minimized.
lolbinarycat
force-pushed
the
rustdoc-extern-reexport-135092
branch
from
2b8ab15 to
3ed1c87
Compare
GuillaumeGomez
approved these changes
Jul 3, 2025
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 3, 2025
…rt-135092, r=GuillaumeGomez rustdoc: fix attrs of locally reexported foreign items fixes rust-lang#135092 also tweaks a few outdated/misleading comments. r? `@GuillaumeGomez`
bors
added a commit
that referenced
this pull request
Jul 3, 2025
Rollup of 5 pull requests Successful merges: - #141831 (rustdoc: fix attrs of locally reexported foreign items) - #143364 (don't include `.md` in title) - #143369 (Various refactorings to the metadata loader) - #143379 (Post {beta,stable}-accepted notifications to compiler/bootstrap backport zulip channels on `{beta,stable}-accepted` label application) - #143384 (Update browser-ui-test version to `0.21.1`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #135092
also tweaks a few outdated/misleading comments.
r? @GuillaumeGomez