-
Notifications
You must be signed in to change notification settings - Fork 13.5k
rust: library: Add setsid
method to CommandExt
trait
#142391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
rust: library: Add setsid
method to CommandExt
trait
#142391
Conversation
rustbot has assigned @workingjubilee. Use |
This comment has been minimized.
This comment has been minimized.
@rustbot label +T-libs-api -T-libs |
This comment has been minimized.
This comment has been minimized.
Add a setsid method to the CommandExt trait so that callers can create a process in a new session and process group whilst still using the POSIX spawn fast path. Tracking issue: rust-lang#105376 Co-Authored-By: Harvey Hunt <harveyhunt@fb.com>
61ae756
to
8285fe4
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot)
|
this doesn't finish building so I don't know what I should be reviewing? |
It appears only Linux supports I guess it should use the exec+fork method instead when setsid is set and the os is not linux? I am also kind of confused as to why compilation didn't fail in the previous PR. |
We have significantly adjusted what we test in "PR CI", the subset of tests we run on every open PR against rust-lang/rust. |
also there is a nightly |
Add a setsid method to the CommandExt trait so that callers can create a process in a new session and process group whilst still using the POSIX spawn fast path.
Tracking issue: #105376
ACP: rust-lang/libs-team#184
This PR was previously submitted by @HarveyHunt (whom I marked as Co-Author in the commit message) in #105377. However that PR went stale.
I applied the suggestion to change the function signature to
fn setsid(&mut self, setsid: bool) -> &mut Command
.