Only work-steal in the main loop for rustc_thread_pool #143035

ywxt · 2025-06-26T01:35:21Z

This PR is a replica of rust-lang/rustc-rayon#12 that only retained work-steal in the main loop for rustc_thread_pool.

rustbot · 2025-06-26T01:35:28Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Zoxc · 2025-06-26T01:43:28Z

compiler/rustc_thread_pool/src/scope/mod.rs

@@ -52,6 +54,12 @@ struct ScopeBase<'scope> {
    /// latch to track job counts
    job_completed_latch: CountLatch,

+    /// Jobs that have been spawned, but not yet started.
+    pending_jobs: Mutex<IndexSet<JobRefId>>,


Why is this swapped to IndexSet?

The lint is "prefer FxHashSet over HashSet, it has better performance".

Should I suppress it?

The impact on performance needs to be measured with rustc-perf. For now, we can keep the original implementation :)

It has been restored.

Zoxc · 2025-06-26T01:45:04Z

You should add me as a co-author for proper copyright assignment.

ywxt · 2025-06-26T01:48:54Z

You should add me as a co-author for proper copyright assignment.

~~How to do it? Sorry, I'm not familiar with it.~~

Done

compiler/rustc_thread_pool/src/broadcast/tests.rs

compiler/rustc_thread_pool/src/registry.rs

compiler/rustc_thread_pool/src/scope/tests.rs

ywxt · 2025-06-26T06:29:05Z

compiler/rustc_thread_pool/src/registry.rs

@@ -796,14 +797,83 @@ impl WorkerThread {
    /// stealing tasks as necessary.


I'm not sure if this comment, which contains "stealing tasks", is still correct after we removed work-steal.

Co-authored-by: Zoxc <zoxc32@gmail.com>

oli-obk · 2025-06-30T12:52:39Z

@bors try @rust-timer queue

Only work-steal in the main loop for rustc_thread_pool This PR is a replica of <rust-lang/rustc-rayon#12> that only retained work-steal in the main loop for rustc_thread_pool. r? `@oli-obk` cc `@SparrowLii` `@Zoxc` `@cuviper` Updates #113349

bors · 2025-06-30T12:53:51Z

⌛ Trying commit 36462f9 with merge 4fc7758...

bors · 2025-06-30T15:10:33Z

☀️ Try build successful - checks-actions
Build commit: 4fc7758 (4fc7758afaab18ef9ab69d63c27cbf058b55d67c)

rust-timer · 2025-06-30T17:20:59Z

Finished benchmarking commit (4fc7758): comparison URL.

Overall result: no relevant changes - BENCHMARK(S) FAILED

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

❗ ❗ ❗ ❗ ❗
Warning ⚠️: The following benchmark(s) failed to build:

include-blob

❗ ❗ ❗ ❗ ❗

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.4%	[2.1%, 2.7%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-4.3%, -2.1%]	6
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 695.172s -> 694.474s (-0.10%)
Artifact size: 372.16 MiB -> 372.22 MiB (0.01%)

oli-obk · 2025-06-30T17:49:57Z

Perf is bricked rn. But detailed perf says 10% regression while the overview says 4% improvement. I'm holding off until perf is back on track

bjorn3 · 2025-06-30T17:54:56Z

It seems like it improves instruction count a bit, but regresses wall time a lot.

Kobzol · 2025-06-30T20:10:01Z

Sorry about the build failure, that was a temporary bug. It shouldn't have affected any perf. numbers though.

SparrowLii · 2025-07-01T01:11:47Z

AFAIK the perf tool only tests single-threaded scenarios, so there should not be such performance regresses. We need to identify the problem.

SparrowLii · 2025-07-01T01:15:29Z

Once the perf tool is fixed, we can try again.

Kobzol · 2025-07-01T05:44:57Z

There is one benchmark that runs with 4 threads in rustc-perf now. We can't compare it by icount though, ofc.

Kobzol · 2025-07-01T05:45:09Z

@bors2 try @rust-timer queue

rust-bors · 2025-07-01T05:45:14Z

⌛ Trying commit 36462f9 with merge c41093d…

To cancel the try build, run the command @bors2 try cancel.

Only work-steal in the main loop for rustc_thread_pool    This PR is a replica of <rust-lang/rustc-rayon#12> that only retained work-steal in the main loop for rustc_thread_pool. r? `@oli-obk` cc `@SparrowLii` `@Zoxc` `@cuviper` Updates #113349

rust-bors · 2025-07-01T07:59:42Z

☀️ Try build successful (CI)
Build commit: c41093d (c41093d894690518d74a99588aa7a0cc9c02c73b, parent: 6988a8fea774a2a20ebebddb7dbf15dd6ef594f9)

rust-timer · 2025-07-01T10:16:40Z

Finished benchmarking commit (c41093d): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.0%, secondary 1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.0%	[2.6%, 3.6%]	3
Regressions ❌ (secondary)	2.6%	[2.1%, 2.9%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.6%	[-0.8%, -0.4%]	3
All ❌✅ (primary)	3.0%	[2.6%, 3.6%]	3

Cycles

Results (primary 1.8%, secondary 2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.2%	[1.4%, 10.8%]	10
Regressions ❌ (secondary)	3.5%	[1.5%, 5.1%]	9
Improvements ✅ (primary)	-1.7%	[-2.6%, -1.0%]	4
Improvements ✅ (secondary)	-3.9%	[-5.3%, -2.5%]	2
All ❌✅ (primary)	1.8%	[-2.6%, 10.8%]	14

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 461.861s -> 463.58s (0.37%)
Artifact size: 372.23 MiB -> 372.20 MiB (-0.01%)

ywxt · 2025-07-01T11:32:42Z

How about this performance, Is it acceptable?

SparrowLii · 2025-07-01T11:35:37Z

~~@Kobzol Are all the cases in this result run with 4 threads?~~

Oh I saw it. serde-1.0.219-threads4 has a performance regression of over 10% :(

SparrowLii · 2025-07-01T11:43:55Z

How about this performance, Is it acceptable?

The wall-time of some cases has regressed. I am confused since these cases are running under single-thread and should not be affected by thread_pool IMO.

We need to identify the cause. I think you can do more local performance testing under single-thread/mult-ithread (like I listed here)

Kobzol · 2025-07-01T11:58:50Z

~~@Kobzol Are all the cases in this result run with 4 threads?~~

Oh I saw it. serde-1.0.219-threads4 has a performance regression of over 10% :(

Note that we are switching the benchmarking collector to a different machine today, and this result was only the second benchmark run produced on the new machine. So if you want to get more stable results, with noise threshold updated, I would wait a few days.

That being said, we currently only have one multithreaded benchmark in the suite. Local benchmarks would probably be more useful here.

rustbot assigned oli-obk Jun 26, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 26, 2025

Zoxc reviewed Jun 26, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 26, 2025

ywxt force-pushed the less-work-steal branch from 699035a to ccd9af7 Compare June 26, 2025 02:21

rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 26, 2025

SparrowLii reviewed Jun 26, 2025

View reviewed changes

compiler/rustc_thread_pool/src/broadcast/tests.rs Show resolved Hide resolved

compiler/rustc_thread_pool/src/registry.rs Show resolved Hide resolved

ywxt commented Jun 26, 2025

View reviewed changes

compiler/rustc_thread_pool/src/scope/tests.rs Show resolved Hide resolved

ywxt commented Jun 26, 2025

View reviewed changes

ywxt force-pushed the less-work-steal branch from a8a202d to 273c9b6 Compare June 26, 2025 06:55

ywxt requested a review from Zoxc June 26, 2025 12:28

ywxt force-pushed the less-work-steal branch from 273c9b6 to a0178fd Compare June 27, 2025 02:42

ywxt and others added 5 commits June 28, 2025 17:58

Only work-steal in the main loop for rustc_thread_pool

0ceac21

Co-authored-by: Zoxc <zoxc32@gmail.com>

Add a comment for the wait_for_jobs function.

44e69f5

Co-authored-by: Zoxc <zoxc32@gmail.com>

Add FIXMEs for those ignored tests.

46e18d1

Restore to HashSet

0ff1fb2

Co-authored-by: Zoxc <zoxc32@gmail.com>

Correct comments.

36462f9

ywxt force-pushed the less-work-steal branch from 486fb86 to 36462f9 Compare June 28, 2025 10:14

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 30, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 30, 2025

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 1, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 1, 2025

		@@ -796,14 +797,83 @@ impl WorkerThread {
		/// stealing tasks as necessary.

Only work-steal in the main loop for rustc_thread_pool #143035

Are you sure you want to change the base?

Only work-steal in the main loop for rustc_thread_pool #143035

Conversation

ywxt commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

rustbot commented Jun 26, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SparrowLii Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zoxc commented Jun 26, 2025

ywxt commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

oli-obk commented Jun 30, 2025

This comment has been minimized.

bors commented Jun 30, 2025

bors commented Jun 30, 2025

This comment has been minimized.

rust-timer commented Jun 30, 2025

Overall result: no relevant changes - BENCHMARK(S) FAILED

oli-obk commented Jun 30, 2025

bjorn3 commented Jun 30, 2025

Kobzol commented Jun 30, 2025

SparrowLii commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SparrowLii commented Jul 1, 2025

Kobzol commented Jul 1, 2025

Kobzol commented Jul 1, 2025

This comment has been minimized.

rust-bors bot commented Jul 1, 2025

rust-bors bot commented Jul 1, 2025

This comment has been minimized.

rust-timer commented Jul 1, 2025

Overall result: no relevant changes - no action needed

ywxt commented Jul 1, 2025

SparrowLii commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SparrowLii commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kobzol commented Jul 1, 2025

ywxt commented Jun 26, 2025 •

edited

Loading

SparrowLii Jun 27, 2025 •

edited

Loading

ywxt commented Jun 26, 2025 •

edited

Loading

SparrowLii commented Jul 1, 2025 •

edited

Loading

SparrowLii commented Jul 1, 2025 •

edited

Loading

SparrowLii commented Jul 1, 2025 •

edited

Loading