-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Stabilize rwlock_downgrade
library feature
#143191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Stabilize rwlock_downgrade
library feature
#143191
Conversation
This means that we can never go back to pthreads to back our locks, but that seems fine since the pthreads API has many issues around UB and movability. @rfcbot merge |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@rfcbot merge |
Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
Tracking Issue: #128203
Method to be stabilized:
I would like to point out that my documentation comment is longer than ideal, but at the same time I don't really know how else to show whyI have made the documentation a bit more clear.downgrade
is actually necessary (instead of just unlocking and relocking). If anyone has ideas for making this more concise that would be great!Stabilization report: #128203 (comment)