Skip to content

fix filename for test #143314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix filename for test #143314

wants to merge 2 commits into from
+1 −0

Conversation

tshepang
Copy link
Member

@tshepang tshepang commented Jul 2, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jul 2, 2025

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 2, 2025
@compiler-errors
Copy link
Member

please squash this into one commit; there's no need to make this two commits if they're both just tiny tweaks.
@compiler-errors
Copy link
Member

@rustbot author
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2025
@compiler-errors
Copy link
Member

compiler-errors commented Jul 2, 2025 •
edited
Loading

Also please adjust the description and PR title to actually reflect what this PR does. I think out of the rename and adding a reference ID, the latter is actually the more important part of this PR, so it would be nice if that had been mentioned.

Because right now the title is very vague.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
3 participants
@tshepang @rustbot @compiler-errors