Skip to content

use unsigned_abs instead of abs on signed int to silence clippy #143356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use unsigned_abs instead of abs on signed int to silence clippy #143356

wants to merge 1 commit into from
+1 −1

Conversation

hkBst
Copy link
Member

@hkBst hkBst commented Jul 3, 2025 •
edited
Loading

Use unsigned_abs instead of abs on signed int to silence clippy. Alternatively we could allow the lint, but if codegen is not affected, then this seems preferable.
@rustbot
Copy link
Collaborator

rustbot commented Jul 3, 2025

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 3, 2025
@scottmcm
Copy link
Member

scottmcm commented Jul 3, 2025

Sounds good; we're making an unsigned type here always so I'd always prefer uN as uM to iN as uM anyway, as easier to think about. And LLVM probably doesn't care either way since iX and uX are the same there.

@bors r+ rollup
@bors
Copy link
Collaborator

bors commented Jul 3, 2025

📌 Commit d9505f0 has been approved by scottmcm

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
4 participants
@hkBst @rustbot @scottmcm @bors