Skip to content

change rustc-abi in custom targets to x86-softfloat#491

Merged
phil-opp merged 1 commit into
mainfrom
fix/soft-float-abi
Feb 6, 2025
Merged

change rustc-abi in custom targets to x86-softfloat#491
phil-opp merged 1 commit into
mainfrom
fix/soft-float-abi

Conversation

@Freax13

@Freax13 Freax13 commented Feb 4, 2025

Copy link
Copy Markdown
Member

With the latest nightly, setting "+soft-float" in "features" is only allowed if "rustc-abi" is set to "x86-softfloat".

Fixes a nightly breakage introduced by rust-lang/rust#136146

With the latest nightly, setting "+soft-float" in "features" is only
allowed if "rustc-abi" is set to "x86-softfloat".
@Freax13 Freax13 requested a review from phil-opp February 4, 2025 05:53
@Freax13

Freax13 commented Feb 4, 2025

Copy link
Copy Markdown
Member Author

Given that 0.9.29 is more widely used than 0.11.9 (probably because of blog_os?), I think we should backport this fix.

@phil-opp phil-opp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@phil-opp phil-opp merged commit b6d3ef4 into main Feb 6, 2025
@Freax13 Freax13 deleted the fix/soft-float-abi branch February 1, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants