Skip to content

Conversation

@phil777
Copy link
Contributor

@phil777 phil777 commented Oct 5, 2025

Checklist:

  • If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
  • I squashed commits belonging together
  • I added unit tests or explained why they are not relevant
  • I executed the regression tests (using tox)
  • If the PR is still not finished, please create a Draft Pull Request

This PR provides a CRC toolbox to compute CRC, create new ones, or search for possible CRC present in a byte string.

@codecov
Copy link

codecov bot commented Oct 5, 2025

Codecov Report

❌ Patch coverage is 46.81648% with 142 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.78%. Comparing base (12a3752) to head (f890e16).
⚠️ Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
scapy/crc.py 46.61% 142 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4855      +/-   ##
==========================================
- Coverage   80.88%   80.78%   -0.11%     
==========================================
  Files         368      369       +1     
  Lines       90340    90607     +267     
==========================================
+ Hits        73069    73194     +125     
- Misses      17271    17413     +142     
Files with missing lines Coverage Δ
scapy/all.py 100.00% <100.00%> (ø)
scapy/crc.py 46.61% <46.61%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@gpotter2
Copy link
Member

gpotter2 commented Oct 22, 2025

Hi ! So this is cool, but I'm a bit unsure if it has a place in Scapy. It looks to me a bit far from networking :/

What do you think?

@polydroi
Copy link

I think it’s useful for some applications, but maybe it would fit better in /modules

@gpotter2
Copy link
Member

We discussed this, it could be fine in modules/, but it needs some documentation. At least docstrings :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants