Skip to content

Remove procedural-masquerade.#278

Closed
emilio wants to merge 1 commit into
masterfrom
proc-masq
Closed

Remove procedural-masquerade.#278
emilio wants to merge 1 commit into
masterfrom
proc-masq

Conversation

@emilio

@emilio emilio commented Dec 13, 2020

Copy link
Copy Markdown
Member

I don't think this is used anymore, so is there any point in keeping the
code around?
@emilio
Remove procedural-masquerade.
885f6a8 
I don't think this is used anymore, so is there any point in keeping the
code around?
@emilio

emilio commented Dec 13, 2020

Copy link
Copy Markdown
Member Author

r? @SimonSapin / @upsuper / @heycam
@SimonSapin

SimonSapin commented Dec 13, 2020

Copy link
Copy Markdown
Member

Although it isn’t used in cssparser anymore it is still used elsewhere: https://crates.io/crates/procedural-masquerade/reverse_dependencies. We could encourage those crate authors to move to plain #[proc_macro] if they require Rust 1.30+ (since procedural-masquerade is only useful on older compilers).

As long as it’s used having a source repository is occasionally useful to make fixes like #274 / rust-lang/rust#73345 (comment)
@emilio

emilio commented Dec 13, 2020

Copy link
Copy Markdown
Member Author

@SimonSapin should we move it to its own repo then? It seems a bit weird to have it in cssparser nowadays.

But anyhow, I'm ok closing this I guess, that's fair :)
@emilio emilio closed this Dec 13, 2020
@emilio emilio deleted the proc-masq branch December 13, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@emilio @SimonSapin