Skip to content

Update usability score thresholds#445

Open
pmachapman wants to merge 1 commit into
masterfrom
update_usability_thresholds
Open

Update usability score thresholds#445
pmachapman wants to merge 1 commit into
masterfrom
update_usability_thresholds

Conversation

@pmachapman

@pmachapman pmachapman commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

These are the updated values from silnlp.


This change is Reviewable

@pmachapman pmachapman requested review from Enkidu93 and ddaspit June 30, 2026 23:20
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.30%. Comparing base (7835067) to head (ab01fc7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #445   +/-   ##
=======================================
  Coverage   73.30%   73.30%           
=======================================
  Files         443      443           
  Lines       37203    37203           
  Branches     5110     5110           
=======================================
  Hits        27272    27272           
  Misses       8805     8805           
  Partials     1126     1126           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ddaspit ddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddaspit reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Enkidu93 and pmachapman).


src/SIL.Machine/QualityEstimation/ChrF3QualityEstimator.cs line 35 at r1 (raw file):

        /// The threshold values used to calculate the usability label for every book or text.
        /// </summary>
        public Thresholds BookThresholds { get; set; } = new Thresholds(greenThreshold: 0.776, yellowThreshold: 0.681);

These values should be constants.

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Will any of the changes here need to be ported as well? Are there plans for silnlp to move to using machine.py for this soon so it's easier to keep the code in sync?

@Enkidu93 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants