Add attached_network_device support to node_interface#491
Merged
Conversation
lo-simon
requested changes
Jun 1, 2026
lo-simon
left a comment
lo-simon
left a comment
Collaborator
There was a problem hiding this comment.
Add a minor update to prevent Ubuntu 24.04 missing initializer for member warning.
Extend node_interface with attached fields, add make_node_interface and parse_node_interface round-trip (including attached_network_device), and unit tests. Co-authored-by: Simon Lo <simon.lo@sony.com> Signed-off-by: Gareth Sylvester-Bradley <garethsb@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend
node_interfacewithattached_fields, addmake_node_interfaceandparse_node_interfaceround-trip, and unit tests.