Add handling for Ranges#267
Merged
Merged
Conversation
jas14
requested changes
Oct 21, 2024
Collaborator
There was a problem hiding this comment.
This is awesome, thanks @lucaseras !
On second thought, let's skip attempting to diff Range objects. As the test files show, because the diff is just (- expected) (+ actual), I don't think it adds any clarity to the failure message beyond what the inspection results already show.
The InspectionTreeBuilder is great and makes the output way more useful:
1) blah blah
Failure/Error: expect(r1).to eq(r2)
- Expected #<Range:0x0000000100de8a18> to eq #<Range:0x0000000100de89f0>.
+ Expected 1..2 to eq 2..3.| :DataObject, | ||
| "super_diff/basic/inspection_tree_builders/data_object" | ||
| ) | ||
| autoload :DateLike, "super_diff/basic/inspection_tree_builders/date_like" |
Collaborator
|
Oh, and don't forget to add a CHANGELOG entry. |
lucaseras
force-pushed
the
lucas/range-diff
branch
from
d8e7cd0 to
01729cc
Compare
jas14
approved these changes
Oct 22, 2024
jas14
left a comment
jas14
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me besides the leftover OperationTreeBuilder autoload. I'll tack on a commit to remove that.
Thanks!
jas14
force-pushed
the
lucas/range-diff
branch
from
9727816 to
ee3bda4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #154