Fix failure case for chained matchers#288
Merged
Merged
Conversation
|
📖 A new version of the docsite has been published at: https://splitwise.github.io/super_diff/branches/286-undefined-expected/847b621f1f5b29a6f09b9d769baf26baa4d6d406 |
|
📖 A new version of the docsite has been published at: https://splitwise.github.io/super_diff/branches/286-undefined-expected/4e9a83f786c08274c4050e5e0d17293470e118e6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #286.
SuperDiff overrides the built-in
RaiseErrormatcher to report that it isdiffable?in most cases. RSpec accordingly assumes that it defines#expected. This issue may have existed since SuperDiff 0.2.0 and RSpec 3.2.0.This PR monkey-patches the
#expectedassumption, much in the same way that we already do for#handle_failure.