Skip to content

Fix integration snippet indentation#299

Merged
jas14 merged 2 commits into
splitwise:mainfrom
gschlager:fix/integration-indent
Feb 14, 2026
Merged

Fix integration snippet indentation#299
jas14 merged 2 commits into
splitwise:mainfrom
gschlager:fix/integration-indent

Conversation

@gschlager

@gschlager gschlager commented Feb 5, 2026

Copy link
Copy Markdown
Contributor

Fixes warning:

super_diff/tmp/integration_spec.rb:17: warning: mismatched indentations at 'end' with 'class' at 15
jas14
jas14 approved these changes Feb 14, 2026
View reviewed changes

@jas14 jas14 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this fixes #283 (comment)!
Comment thread spec/support/integration/test_programs/base.rb
begin
RSpec::Expectations.configuration.on_potential_false_positives = :nothing
#{reindent(code, level: 3)}
#{reindent(code, level: 3)}

@jas14 jas14 Feb 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, I previously tried to fiddle with level, including adjusting to 2, which didn't fix it. And now I see that it's because it might make the first line indented correctly, but the subsequent ones in code wouldn't be.
gschlager and others added 2 commits February 13, 2026 18:40
@gschlager @jas14
Fix integration snippet indentation
20a8099 
Fixes warning:

```
super_diff/tmp/integration_spec.rb:17: warning: mismatched indentations at 'end' with 'class' at 15
```
@jas14
Add CHANGELOG entry
19c4bcc
@jas14 jas14 force-pushed the fix/integration-indent branch from 972d1f6 to 19c4bcc Compare February 14, 2026 00:41
@jas14 jas14 merged commit 681b2b6 into splitwise:main Feb 14, 2026
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@gschlager @jas14