Conversation
941a56d to
2b64a72
Compare
|
I'm noticing a few spots in which old references exist in the docs. Going to list them here in case we want them updated prior to merging: |
Did you re-build the docs? I just did, and I'm not seeing any (all?) of those examples. The API docs are auto-generated. I do see some dangling references in |
|
I think you're right. I was misinterpreting the results of that grep |
mmcfarland
left a comment
There was a problem hiding this comment.
These changes look good to me. I think there's one more file, scripts/wait-for-it.sh that is no longer used and could also be deleted.
As you mentioned in the PR, without a default backend, it's a little difficult to run/test changes without coordinating with a new backend repo. Do you have general (or specific) ideas about what the best dev workflow for updating this project with a backend? As a proof of concept, I tried mimicking a git submodule approach: cloning stac-fastapi into a gitignored subdirectory of stac-fastapi-pgstac and modifying the dockerfile there to do an editable install of these packages. Seemed a bit clumsy but should work. Perhaps when we've got a good flow we can update the development documentation here.
pjhartzell
left a comment
There was a problem hiding this comment.
Just a question about the docs.
Agreed.
In the past, I've used my IDE's "workspace" concept, coupled with a virtual environment that has both packages installed in editable mode, to work on two repos at once. I think a similar approach could work here. That's relies more on a non-Docker development environment, so your submodule approach also seems good. |
Related Issue(s):
Description:
No functional code changes. Removes the two backends, they live on their own now:
It'd be nice to have a in-memory backend that we could use to exercise the API w/o a database, but that's a pretty significant lift. Something for the future, perhaps.
This is such a major change to the infrastructure (not the code) that I'd like to get at least two approving reviews on it.
PR Checklist:
pre-commithooks pass locallymake test)make docs)