Skip to content
This repository was archived by the owner on Oct 26, 2022. It is now read-only.

Integration testing against Ruby 2.6 #42

Merged
thebadmonkeydev merged 5 commits into from
Feb 28, 2019
Merged

Integration testing against Ruby 2.6 #42

thebadmonkeydev merged 5 commits into from
Feb 28, 2019

Conversation

@thebadmonkeydev
Copy link
Contributor

@thebadmonkeydev thebadmonkeydev commented Feb 28, 2019 •
edited
Loading

Problem

We're on the heels of Ruby 2.3 dropping out of support and ruby 2.6 is seeing serious production usage. It's time we start testing against 2.6.

Solution

There a few things here:

  1. Removed explicit bundler install in before_install in travis config...turns out, travis is doing more autodetection than I knew and bundler and the gem bundle were being installed/created before these scripts even ran.
  2. Remove individual patch versions of ruby so that we'll build against the current patch version each time
  3. Added Ruby 2.6 to our test matrix config
  4. I also reverted the Gemfile.lock bundler version change because of weirdness getting bundler 2 and ruby 2.6 to work together on Travis.

Notes

I also removed a premature version bump in GraphQL::Cache::VERSION

Resolves #41
@thebadmonkeydev
Remove patch version sepcifics from ruby test list
2ae8da6
@thebadmonkeydev
Add ruby 2.6 test env
7ee5994
@thebadmonkeydev
Fix bad gem version bump in lockfile
9b68111
@thebadmonkeydev
Revert dev usage to bundler 1.17.3
de25576
@thebadmonkeydev
Remove explicit bundle install from test bootstrap
72f5535 
Turns out Travis detects a lot of this stuff for us and these bundle
commands were being run AFTER travis already installed bundler and
installed project gems
@thebadmonkeydev thebadmonkeydev requested review from a user and jeromedalbert February 28, 2019 15:37
@thebadmonkeydev thebadmonkeydev self-assigned this Feb 28, 2019
@thebadmonkeydev
Copy link
Contributor Author

thebadmonkeydev commented Feb 28, 2019

Add support for ruby 2.6 in graphql-cache
@thebadmonkeydev thebadmonkeydev changed the title 41 ruby 2 6 Feb 28, 2019
@thebadmonkeydev thebadmonkeydev merged commit 20dcf6a into master Feb 28, 2019
@thebadmonkeydev thebadmonkeydev deleted the 41-ruby-2-6 branch February 28, 2019 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants

@thebadmonkeydev