Include py.typed and enable type annotations for the package - #1104
Merged
Conversation
richardm-stripe
requested review from
a team and
anniel-stripe
and removed request for
a team
October 26, 2023 21:31
pakrym-stripe
approved these changes
Oct 26, 2023
pakrym-stripe
left a comment
pakrym-stripe
left a comment
Contributor
There was a problem hiding this comment.
Can you please add a description for this one?
richardm-stripe
enabled auto-merge (squash)
October 27, 2023 00:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes
setup.pyso that inline type annotations are enabled for thestripe-pythonpackage. Up until now, the type annotations were just hanging out, existing, but would not be analyzed by type checkers without special effort. Now, anybody who doespip install stripewill experience the inline types. (subject to the resolution order).See more at the wiki page.