⬆️(dependencies) bump blocknote to 0.44.2 #1733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
fix/issue-text-overwriten-goback
branch
from
ed28a34 to
aae1584
Compare
This was referenced Dec 12, 2025
AntoLC
force-pushed
the
fix/issue-text-overwriten-goback
branch
from
aae1584 to
68bc2b4
Compare
|
Size Change: +721 B (+0.02%) Total Size: 4.14 MB
|
AntoLC
force-pushed
the
fix/issue-text-overwriten-goback
branch
3 times, most recently
from
055e256 to
75b7d90
Compare
Ovgodd
approved these changes
Dec 16, 2025
Collaborator
Ovgodd
left a comment
Ovgodd
left a comment
There was a problem hiding this comment.
good for me ( just suggested 2 changes )
|
|
||
| // Should not happen | ||
| if (!editor) { | ||
| if (!editor || !editor._tiptapEditor?.view?.dom) { |
Collaborator
There was a problem hiding this comment.
nit :
Suggested change
| if (!editor || !editor._tiptapEditor?.view?.dom) { | |
| const isEditorReady = Boolean(editor) && | |
| Boolean(editor._tiptapEditor?.view?.dom); | |
| if (!isEditorReady ) { |
Collaborator
Author
There was a problem hiding this comment.
It helps the linter to understand that editor is set, if we do as suggested, you get lint error:
Comment on lines
+104
to
+108
| onKeyDown={(e) => { | ||
| if (e.key === 'Escape' && openEmojiPicker) { | ||
| setOpenEmojiPicker(false); | ||
| } | ||
| }} |
Collaborator
There was a problem hiding this comment.
Might be worth extracting this inline handler to keep the JSX more readable.maybe like this :
const handleEmojiButtonKeyDown = ( event: React.KeyboardEvent<HTMLElement> ) => { if (event.key === 'Escape' && openEmojiPicker) { event.stopPropagation(); setOpenEmojiPicker(false); } };
Collaborator
Author
There was a problem hiding this comment.
For big chunk of code I agree it is better, but for small snippet I find it is easier to have it directly on the component, I don't have to search where the function is, I can see directly what it is doing like that.
AntoLC
force-pushed
the
fix/issue-text-overwriten-goback
branch
from
75b7d90 to
01d6625
Compare
We bump the blocknote dependencies to version 0.44.2 to incorporate the latest features and bug fixes. It seems to fix an issue with Titap, when the text was selected and the user clicked on the Go Back button of the browser, the application was crashing. "[tiptap error]: The editor view is not available. Cannot access view['dom']. The editor may not be mounted yet."
WebSocketStatus.Connected does not mean we are totally connected because authentication can still be in progress and failed. So we will use the event onAuthenticated to assert that we are fully connected.
The recent update of Blocknote brokes a test because a element was not easily accessible anymore. We improved the CalloutBlock to be able to be closed when "escape" is pressed, we improve the positionning of the EmojiPicker too.
AntoLC
force-pushed
the
fix/issue-text-overwriten-goback
branch
from
01d6625 to
2f612db
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We bump the blocknote dependencies to version 0.44.2 to incorporate the latest features and bug fixes.
It seems to fix an issue with Titap, when the text was selected and the user clicked on the Go Back button of the browser, the application was crashing.