Skip to content

Conversation

@AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Jan 13, 2026

Purpose

We were not properly sanitizing props passed to the InterlinkingLinkInlineContent component, which could lead to XSS attacks. This commit remove most of the props and only keep the necessary ones.

@AntoLC AntoLC self-assigned this Jan 13, 2026
@AntoLC AntoLC added bug Something isn't working frontend labels Jan 13, 2026
@AntoLC AntoLC force-pushed the secu/interlinking-props branch from 6bda93b to b168830 Compare January 13, 2026 09:41
@AntoLC AntoLC requested review from lunika and removed request for lunika January 13, 2026 09:43
@AntoLC AntoLC force-pushed the secu/interlinking-props branch 2 times, most recently from 9542314 to eaf47ba Compare January 13, 2026 10:31
@github-actions
Copy link

github-actions bot commented Jan 13, 2026

Size Change: +303 B (+0.01%)

Total Size: 4.18 MB

Filename Size Change
apps/impress/out/_next/static/30e0f4b7/_buildManifest.js 0 B -887 B (removed) 🏆
apps/impress/out/_next/static/chunks/1015.js 0 B -768 kB (removed) 🏆
apps/impress/out/_next/static/chunks/3812.js 768 kB +768 kB (new file) 🆕
apps/impress/out/_next/static/fa0cfc4f/_buildManifest.js 887 B +887 B (new file) 🆕

compressed-size-action

@AntoLC AntoLC requested a review from lunika January 13, 2026 10:44
@AntoLC AntoLC force-pushed the secu/interlinking-props branch from eaf47ba to 3a14cdf Compare January 13, 2026 11:32
@socket-security
Copy link

socket-security bot commented Jan 13, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm entities is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: ?npm/mjml@4.18.0npm/@html-to/text-cli@0.5.4npm/entities@4.5.0

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/entities@4.5.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm entities is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: ?npm/entities@6.0.1

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/entities@6.0.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm js-beautify is 100.0% likely obfuscated

Confidence: 1.00

Location: Package overview

From: ?npm/mjml@4.18.0npm/js-beautify@1.15.1

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/js-beautify@1.15.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm vite is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: ?npm/vitest@4.0.16npm/vite@7.1.12

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/vite@7.1.12. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@AntoLC AntoLC force-pushed the secu/interlinking-props branch from 3a14cdf to 04cfa16 Compare January 13, 2026 12:09
We were not properly sanitizing props passed to the
InterlinkingLinkInlineContent component, which could
lead to XSS attacks. This commit remove most of the
props and only keep the necessary ones.
@AntoLC AntoLC force-pushed the secu/interlinking-props branch from 04cfa16 to e807237 Compare January 13, 2026 12:14
@AntoLC AntoLC merged commit e807237 into main Jan 13, 2026
27 of 28 checks passed
@AntoLC AntoLC deleted the secu/interlinking-props branch January 13, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend

3 participants