✅(e2e) fix e2e test for other browsers #1799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anto59290
force-pushed
the
fix-test-e2e-comments
branch
from
2e7082c to
3afa82e
Compare
AntoLC
force-pushed
the
fix-test-e2e-comments
branch
from
3afa82e to
16b763d
Compare
In this test the comment is made using the "current" browser which can be Chromium but can also be Firefox or Webkit. This is why the test failed with other browsers. Signed-off-by: Anto59290 <antonin59290@hotmail.com>
AntoLC
force-pushed
the
fix-test-e2e-comments
branch
from
16b763d to
f9f32db
Compare
Contributor
Author
|
Thank you @AntoLC for taking the time to push this forward |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this test the comment is made using the "current" browser which can be Chromium but can also be Firefox or Webkit.
This is why the test failed with other browsers.
There is one other occurence in this issue in src/frontend/apps/e2e/tests/app-impress/doc-inherited-share.spec.ts, but the test always fails on my locahost for whatever reason so I did not make the change
Purpose
Make the test pass in the CI.
Proposal
External contributions
Thank you for your contribution! 🎉
Please ensure the following items are checked before submitting your pull request:
git commit --signoff(DCO compliance)git commit -S)<gitmoji>(type) title description## [Unreleased]section (if noticeable change)