Skip to content

Conversation

@edgurgel
Copy link
Member

@edgurgel edgurgel commented Nov 21, 2025

Follow-up from supabase/walrus#77

What kind of change does this PR introduce?

Filter postgres changes based on action

@edgurgel edgurgel changed the title WIP Nov 21, 2025
@blacksmith-sh

This comment has been minimized.

@coveralls
Copy link

coveralls commented Nov 21, 2025

Coverage Status

coverage: 88.634% (+0.04%) from 88.596%
when pulling f4a91f4 on feat/postgres-changes-action-filter
into e86e984 on main.

@edgurgel edgurgel force-pushed the feat/postgres-changes-action-filter branch from e4000c5 to c3583e6 Compare December 4, 2025 03:28
@edgurgel edgurgel changed the title WIP: filter postgres changes by action Dec 4, 2025
@edgurgel edgurgel force-pushed the feat/postgres-changes-action-filter branch from c3583e6 to 2baeee3 Compare December 4, 2025 09:01
@edgurgel edgurgel marked this pull request as ready for review December 5, 2025 02:58
Copy link
Member

@filipecabaco filipecabaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we already ship the walrus change?

transaction(conn, fn conn ->
Enum.map(subscription_list, fn %{id: id, claims: claims, subscription_params: params = {schema, table, filters}} ->
case query(conn, sql, [publication, schema, table, id, claims, filters]) do
Enum.map(subscription_list, fn %{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

later we should extract this to a function as this is a bit cluttered but not important now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Will refactor!

@edgurgel
Copy link
Member Author

did we already ship the walrus change?

The walrus PR has been merged if that's the question 🤔

@filipecabaco
Copy link
Member

yes it was 😁 didn't remember if it did happen approving to unblock

@edgurgel edgurgel force-pushed the feat/postgres-changes-action-filter branch from a4ddb1a to f293c72 Compare December 28, 2025 20:27
@edgurgel edgurgel force-pushed the feat/postgres-changes-action-filter branch from f293c72 to f4a91f4 Compare January 30, 2026 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants